viirya commented on issue #2296: URL: https://github.com/apache/arrow-rs/issues/2296#issuecomment-1204215694
At second glance, JsonEqual functionality is used by `ArrowJson` to compare with another `RecordBatchReader`. Underlying JSON record batch `ArrowJsonBatch` is compared with `RecordBatch`. Although the stuffs like `ArrowJson` is under integration_util, and it is indeed used by integration test. But it seems to be only used as intermediate format to read JSON data and convert to arrow array. I don't see that JSON is compared directly with arrow arrays (I may miss it if it is deep). Currently seems the JsonEqual functionality is only used in some IPC tests where JSON files are read and compare with arrow arrays without converting. For that tests, I think we can follow integration test to convert JSON to arrow arrays before comparing. I can take some time on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
