pitrou commented on PR #13783: URL: https://github.com/apache/arrow/pull/13783#issuecomment-1204997637
> The existing set of predicates is both confusing and incomplete, so I'd argue for both documenting and adding predicates Hmm... can you point out the causes for confusion? Perhaps there's a way to improve that. Same for incompleteness: is the set of `Type::type` predicates incomplete? if so, we should add the missing and desired predicates. > Suppose we agree that a predicate corresponding to PrimitiveTypes should be added, since is_primitive is not the one Why is `is_primitive` not the one? It seems like it is returning the desired information, is it not? (is it missing some types perhaps?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
