ManManson commented on code in PR #13796:
URL: https://github.com/apache/arrow/pull/13796#discussion_r939491544
##########
cpp/src/arrow/filesystem/filesystem.h:
##########
@@ -132,6 +133,9 @@ struct ARROW_EXPORT FileSelector {
bool recursive;
/// The maximum number of subdirectories to recurse into.
int32_t max_recursion;
+ /// How many partitions should be processed in parallel. May not be
supported by all
+ /// implementations of `GetFileSystemGenerator`.
+ util::optional<int32_t> partitions_readahead;
Review Comment:
Are there any practical reasons why you do avoid optionals in public APIs?
Does Arrow try to maintain strict ABI stability across multiple releases? If
not, then I guess it should be completely fine.
Regarding `directory_readahead`: I agree, the term `partitions` does not
belong to this level of abstraction. I'll change it to `directory_readahead`,
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
