liukun4515 commented on issue #2320: URL: https://github.com/apache/arrow-rs/issues/2320#issuecomment-1207199534
> I find it unexpected that a variable length byte array outperforms a fixed-length i128? > > > reduce construct the decimal128 and decimal258 which contain the useless precision/scale for validation. It's not variable length byte array. I think should be a fixed length byte array, for example decimal128 is [u8;16], decimal256 is [u8;32]. Have you benched these two implementation? In current logic, we should get the byte array and convert the byte array to i128 or bigint/string first, and then compare with the bound min/max value. I guess we can just compare the fixed length byte array with the bound min/max with the format of fixed length byte array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
