Ted-Jiang commented on code in PR #2359:
URL: https://github.com/apache/arrow-rs/pull/2359#discussion_r939821838
##########
parquet/src/arrow/record_reader/mod.rs:
##########
@@ -198,12 +198,6 @@ where
self.num_records += buffered_records;
self.num_values += buffered_values;
- self.consume_def_levels();
Review Comment:
@tustvold FYI,
Sometimes like `batch_size` is = 20, when read 15 records without consume.
Then skip 50 records, finally read 5 records for one batch.
If we call these consume api during skip, we will lose the 15 records.
Do you think remove these is reasonable 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
