ManManson commented on code in PR #13796:
URL: https://github.com/apache/arrow/pull/13796#discussion_r939990171
##########
cpp/src/arrow/filesystem/localfs.h:
##########
@@ -34,10 +34,24 @@ namespace fs {
/// Options for the LocalFileSystem implementation.
struct ARROW_EXPORT LocalFileSystemOptions {
+ static constexpr uint32_t kDefaultDirectoryReadahead = 1u;
+ static constexpr uint32_t kDefaultBatchSize = 1000u;
Review Comment:
Just curious: why are `uint32_t`:s bad?
##########
cpp/src/arrow/filesystem/localfs.h:
##########
@@ -34,10 +34,24 @@ namespace fs {
/// Options for the LocalFileSystem implementation.
struct ARROW_EXPORT LocalFileSystemOptions {
+ static constexpr uint32_t kDefaultDirectoryReadahead = 1u;
+ static constexpr uint32_t kDefaultBatchSize = 1000u;
+
/// Whether OpenInputStream and OpenInputFile return a mmap'ed file,
/// or a regular one.
bool use_mmap = false;
+ /// Options related to `GetFileSystemGenerator` interface.
+
+ /// How many directories should be processed in parallel
+ /// by the `GetFileSystemGenerator` impl.
+ uint32_t directory_readahead = kDefaultDirectoryReadahead;
+ /// Specifies how much entries shall be aggregated into
+ /// a single FileInfoVector chunk by the `GetFileSystemGenerator` impl, which
+ /// is the result of `stat`:ing individual dirents, obtained by the call to
+ /// `internal::ListDir`.
+ uint32_t batch_size = kDefaultBatchSize;
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
