pitrou commented on code in PR #13796:
URL: https://github.com/apache/arrow/pull/13796#discussion_r940103686
##########
cpp/src/arrow/filesystem/localfs.h:
##########
@@ -34,10 +34,24 @@ namespace fs {
/// Options for the LocalFileSystem implementation.
struct ARROW_EXPORT LocalFileSystemOptions {
+ static constexpr uint32_t kDefaultDirectoryReadahead = 1u;
+ static constexpr uint32_t kDefaultBatchSize = 1000u;
Review Comment:
They are not bad per se, but the general tendency should be to use them only
when necessary (for example you want to perform unsigned computations, or are
you reading data provided by a third-party API), as otherwise you inevitably
end up mixing signed and unsigned which is generally annoying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
