tustvold commented on code in PR #2381:
URL: https://github.com/apache/arrow-rs/pull/2381#discussion_r940703571
##########
parquet/src/util/bit_util.rs:
##########
@@ -398,22 +397,7 @@ impl BitReader {
///
/// Returns `false` if there are no more values to skip, `true` otherwise.
pub fn skip_value(&mut self, num_bits: usize) -> bool {
- assert!(num_bits <= 64);
-
- if self.byte_offset * 8 + self.bit_offset + num_bits >
self.total_bytes * 8 {
- return false;
- }
-
- self.bit_offset += num_bits;
-
- if self.bit_offset >= 64 {
- self.byte_offset += 8;
- self.bit_offset -= 64;
-
- self.reload_buffer_values();
- }
-
- true
+ self.skip(1, num_bits) == 1
Review Comment:
This isn't actually called by anything I can find, so lets just keep it
simple
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
