HaoYang670 commented on issue #2362: URL: https://github.com/apache/arrow-rs/issues/2362#issuecomment-1208686700
> For unsafe paths, we run value validation which includes such check. Here the problem is that we may do redundant validation. > For safe paths, I think it assumes the inputs are all valid (including decimal type). That's the concern. `safe` means soundness. However `DataType::Decimal(usize, usize)` is unsound because it allows you to do `False` things without compile (or runtime) error. For example `Decimal(10000000000, 10000000000)` is invalid but you can do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
