assignUser commented on code in PR #13845:
URL: https://github.com/apache/arrow/pull/13845#discussion_r943275293
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1019,12 +1019,13 @@ if(ARROW_USE_BOOST)
# Find static boost headers and libs
set(Boost_USE_STATIC_LIBS ON)
endif()
+ if(ARROW_BOOST_REQUIRE_LIBRARY)
+ set(ARROW_BOOST_COMPONENTS "COMPONENTS;system;filesystem")
+ endif()
resolve_dependency(Boost
REQUIRED_VERSION
${ARROW_BOOST_REQUIRED_VERSION}
- COMPONENTS
- system
- filesystem
+ ${ARROW_BOOST_COMPONENTS}
Review Comment:
What is the advantage of your approach? The `COMPONENTS` arg completely
missing or being empty has the same effect as `if(ARG_COMPONENTS)` will be
false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
