trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r493036448
##########
File path: js/test/inference/column.ts
##########
@@ -33,33 +33,6 @@ const boolColumn = new Column(new Field('bool', boolType), [
expect(typeof boolVector.get(0) === 'boolean').toBe(true);
expect(typeof boolColumn.get(0) === 'boolean').toBe(true);
-type NamedSchema = {
- a: Int8;
- b: Utf8;
- c: Dictionary<List<Bool>>;
-};
-
-const mapChildFields = [
- { name: 'a', type: new Int8() },
- { name: 'b', type: new Utf8() },
- { name: 'c', type: new Dictionary<List<Bool>>(null!, null!) }
-].map(({ name, type }) => new Field(name, type));
-
-const mapType = new Map_<NamedSchema>(mapChildFields);
-
-const mapVector = Vector.new(Data.Map(mapType, 0, 0, 0, null, []));
-const mapColumn = new Column(new Field('map', mapType, false), [
- Vector.new(Data.Map(mapType, 0, 0, 0, null, [])),
- Vector.new(Data.Map(mapType, 0, 0, 0, null, [])),
- Vector.new(Data.Map(mapType, 0, 0, 0, null, [])),
-]);
-
-const { a: a1, b: b1, c: c1 } = mapVector.get(0)!;
-const { a: a2, b: b2, c: c2 } = mapColumn.get(0)!;
-
-console.log(a1, b1, c1);
-console.log(a2, b2, c2);
-
Review comment:
Oh the one that tests the Map type was old, and should be covered by the
nested types in the Struct test here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
