cyb70289 commented on a change in pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#discussion_r492543154
##########
File path: cpp/src/arrow/compute/kernel.h
##########
@@ -664,7 +664,7 @@ struct VectorKernel : public ArrayKernel {
using ScalarAggregateConsume = std::function<void(KernelContext*, const
ExecBatch&)>;
using ScalarAggregateMerge =
- std::function<void(KernelContext*, const KernelState&, KernelState*)>;
+ std::function<void(KernelContext*, KernelState&, KernelState*)>;
Review comment:
Yes. Pass rvalue makes it more explicit. Will change.
##########
File path: cpp/src/arrow/compute/kernel.h
##########
@@ -664,7 +664,7 @@ struct VectorKernel : public ArrayKernel {
using ScalarAggregateConsume = std::function<void(KernelContext*, const
ExecBatch&)>;
using ScalarAggregateMerge =
- std::function<void(KernelContext*, const KernelState&, KernelState*)>;
+ std::function<void(KernelContext*, KernelState&, KernelState*)>;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
