Ted-Jiang commented on code in PR #2407:
URL: https://github.com/apache/arrow-rs/pull/2407#discussion_r944182380
##########
parquet/src/util/test_common/page_util.rs:
##########
@@ -166,11 +167,28 @@ impl<P: Iterator<Item = Page> + Send> PageReader for
InMemoryPageReader<P> {
}
fn peek_next_page(&mut self) -> Result<Option<PageMetadata>> {
- unimplemented!()
+ if let Some(x) = self.page_iter.peek() {
+ match x {
+ Page::DataPage { .. } => {
+ unreachable!()
Review Comment:
I my mind , i think most application(like spark) still use v1 page(which not
supported `DeltaBitPack`). Is iox using datapagev2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
