HaoYang670 commented on code in PR #2413:
URL: https://github.com/apache/arrow-rs/pull/2413#discussion_r944440652
##########
arrow/src/array/builder/struct_builder.rs:
##########
@@ -233,6 +236,28 @@ impl StructBuilder {
let array_data = unsafe { builder.build_unchecked() };
StructArray::from(array_data)
}
+
+ /// Constructs and validates contents in the builder to ensure that
+ /// - fields and field_builders are of equal length
+ /// - the number of items in individual field_builders are equal to
self.len
+ /// - the number of items in individual field_builders are equal to
self.null_buffer_builder.len()
+ fn validate_content(&self) {
+ if self.fields.len() != self.field_builders.len() {
+ panic!("Number of fields is not equal to the number of
field_builders.");
+ }
+ if !self.field_builders.iter().all(|x| x.len() == self.len) {
+ panic!("StructBuilder and field_builders are of unequal lengths.");
+ }
+ if !self
+ .field_builders
+ .iter()
+ .all(|x| x.len() == self.null_buffer_builder.len())
Review Comment:
Oh, wait! We don't need to check the null buffer length at all. As we can
make sure that the length of null buffer builder is always equal to `self.len`.
@tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
