viirya commented on code in PR #2449:
URL: https://github.com/apache/arrow-rs/pull/2449#discussion_r946082565
##########
.github/workflows/integration.yml:
##########
@@ -46,22 +69,47 @@ jobs:
with:
path: rust
fetch-depth: 0
- - name: Setup Python
- uses: actions/setup-python@v4
- with:
- python-version: 3.8
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- run: archery docker run -e ARCHERY_INTEGRATION_WITH_RUST=1
conda-integration
+ - name: Make build directory
+ run: mkdir /build
+ - name: Build Rust
+ run: conda run --no-capture-output ci/scripts/rust_build.sh $PWD /build
+ - name: Build C++
+ run: conda run --no-capture-output ci/scripts/cpp_build.sh $PWD /build
+ - name: Build C#
+ run: conda run --no-capture-output ci/scripts/csharp_build.sh $PWD
/build
+ - name: Build Go
+ run: conda run --no-capture-output ci/scripts/go_build.sh $PWD
+ - name: Build Java
+ run: conda run --no-capture-output ci/scripts/java_build.sh $PWD /build
+ # Temporarily disable JS
https://issues.apache.org/jira/browse/ARROW-17410
+ # - name: Build JS
+ # run: conda run --no-capture-output ci/scripts/js_build.sh $PWD /build
+ - name: Install archery
+ run: conda run --no-capture-output pip install -e dev/archery
+ - name: Run integration tests
+ run: |
+ conda run --no-capture-output archery integration \
+ --run-flight \
+ --with-cpp=1 \
+ --with-csharp=1 \
+ --with-java=1 \
+ --with-js=0 \
+ --with-go=1 \
+ --with-rust=1 \
+ --gold-dirs=testing/data/arrow-ipc-stream/integration/0.14.1 \
+ --gold-dirs=testing/data/arrow-ipc-stream/integration/0.17.1 \
+
--gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-bigendian \
+
--gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-littleendian \
+
--gold-dirs=testing/data/arrow-ipc-stream/integration/2.0.0-compression \
+
--gold-dirs=testing/data/arrow-ipc-stream/integration/4.0.0-shareddict
Review Comment:
I think the change here is to move executing commends from docker-compose
(`conda-integration`) to separate CI steps. The advantage is easier to control
each step for each implementations (e.g. disabling JS).
Although we don't move from `archery`, there is still a slight disadvantage
that we maintain the execution here and if any change is made in arrow repo, we
might miss it at first.
There is some overhead but not as much as moving from `archery`, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
