pitrou commented on code in PR #13887:
URL: https://github.com/apache/arrow/pull/13887#discussion_r946451372
##########
go/parquet/file/column_reader.go:
##########
@@ -136,8 +138,8 @@ type columnChunkReader struct {
// NewColumnReader returns a column reader for the provided column initialized
with the given pagereader that will
// provide the pages of data for this column. The type is determined from the
column passed in.
-func NewColumnReader(descr *schema.Column, pageReader PageReader, mem
memory.Allocator) ColumnChunkReader {
- base := columnChunkReader{descr: descr, rdr: pageReader, mem: mem,
decoders: make(map[format.Encoding]encoding.TypedDecoder)}
+func NewColumnReader(descr *schema.Column, pageReader PageReader, mem
memory.Allocator, bufferPool *sync.Pool) ColumnChunkReader {
Review Comment:
Shouldn't you add a terse description of the new parameter?
(especially as the type isn't self-descriptive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
