tustvold opened a new issue, #2463: URL: https://github.com/apache/arrow-rs/issues/2463
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.** <!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] (This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*) --> Unlike `SerializedFileReader`, or `SerializedRowGroupReader`, `SerializedPageReader` is created with a `T: Read` instead of `R: ChunkReader`. In order to preserve this when creating the async reader, I created a separate `InMemoryColumnChunkReader`. Similarly when adding page skipping support in #2044 a `VecDeque<T>` was passed into the constructor, to avoid changing the signature. Whilst working on #2460 we find ourselves in the same position where the lack of a ChunkReader complicates matters **Describe the solution you'd like** <!-- A clear and concise description of what you want to happen. --> I think we have reached a point where introducing a breaking change to push the `ChunkReader` into `SerializedPageReader` is justified, as it will allow unifying `InMemoryColumnChunkReader` with `SerializedPageReader` and eliminating a load of additional complexity **Describe alternatives you've considered** <!-- A clear and concise description of any alternative solutions or features you've considered. --> **Additional context** <!-- Add any other context or screenshots about the feature request here. --> FYI @Ted-Jiang @thinkharderdev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
