milesgranger commented on code in PR #13894:
URL: https://github.com/apache/arrow/pull/13894#discussion_r946738274
##########
cpp/src/arrow/array/array_nested.h:
##########
@@ -127,11 +127,15 @@ class ARROW_EXPORT ListArray : public
BaseListArray<ListType> {
/// allocated because of null values
static Result<std::shared_ptr<ListArray>> FromArrays(
const Array& offsets, const Array& values,
- MemoryPool* pool = default_memory_pool());
+ MemoryPool* pool = default_memory_pool(),
+ int64_t null_count = -1,
+ std::shared_ptr<Buffer> null_bitmap = NULLPTR);
Review Comment:
Good point. ~I noticed the ordering part, but thought placing it after
memory pool would lead to less API breakage since the two added have defaults.
But inclined to agree, maybe it's better to have parameter order consistent. 👍~
I misread your comment.. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
