tustvold commented on code in PR #2464:
URL: https://github.com/apache/arrow-rs/pull/2464#discussion_r946982113
##########
parquet/src/file/writer.rs:
##########
@@ -1062,11 +1063,25 @@ mod tests {
page_writer.close().unwrap();
}
{
+ let reader = bytes::Bytes::from(buffer);
+
+ let t = types::Type::primitive_type_builder("t", physical_type)
+ .build()
+ .unwrap();
+
+ let desc = ColumnDescriptor::new(Arc::new(t), 0, 0,
ColumnPath::new(vec![]));
Review Comment:
This is somewhat cumbersome, but I opted to take ColumnChunkMetadata in the
constructor as it is more future-proof, not to mention slightly more obvious
what the values are. In particular it avoids ambiguity over whether values
includes nulls (it does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
