thinkharderdev commented on code in PR #2473:
URL: https://github.com/apache/arrow-rs/pull/2473#discussion_r947757732
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -116,6 +118,62 @@ impl RowSelection {
Self { selectors }
}
+ /// Given an offset index, return a mask indicating which pages are
selected along with their locations by `self`
+ pub fn page_mask(
+ &self,
+ page_locations: &[PageLocation],
+ ) -> (Vec<bool>, Vec<Range<usize>>) {
Review Comment:
The idea was to just do it it one shot to avoid iterating over the locations
again to get the ranges, but perhaps it's better to avoid overloading
Edit: Looking at this again, the `mask` was part of a previous design that
is no longer relevant, so I think we can just rename this and only return the
ranges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
