icexelloss commented on PR #13880: URL: https://github.com/apache/arrow/pull/13880#issuecomment-1219560042
@rtpsw At high level the changes make sense to me. My two main questions are * I haven't seen much use of macros in this way in Acero code. I think those are probably fine would like to hear opinions from maintainers, perhaps @westonpace or @rok * I still don't full grasp the need for the KeyHasher class, some more elaboration will probably help to understand the justification. Is KeyHasher strictly better than the current hashing logic in hash join node? (if so, we can unify those two?) Or it is better because of the way asof join works? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
