josiahyan commented on a change in pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#discussion_r494709994
##########
File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java
##########
@@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {
*/
@Override
public int getValueCapacity() {
- return capAtMaxInt(validityBuffer.capacity() * 8);
+ return actualValueCapacity;
+ }
+
+ @Override
+ protected void refreshValueCapacity() {
+ actualValueCapacity = capAtMaxInt(validityBuffer.capacity() * 8);
Review comment:
Hmm that means that this wasn't picked up on a unit test for some
reason; handleSafe threads through the same implementation, looking at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
