eitsupi commented on code in PR #13934:
URL: https://github.com/apache/arrow/pull/13934#discussion_r950712963
##########
r/R/dplyr-distinct.R:
##########
@@ -35,8 +29,24 @@ distinct.arrow_dplyr_query <- function(.data, ..., .keep_all
= FALSE) {
# distinct() with no vars specified means distinct across all cols
.data <- dplyr::group_by(.data, !!!syms(names(.data)))
}
-
- out <- dplyr::summarize(.data, .groups = "drop")
+ if (.keep_all == TRUE) {
Review Comment:
```suggestion
if (isTRUE(.keep_all)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
