eitsupi commented on code in PR #13748:
URL: https://github.com/apache/arrow/pull/13748#discussion_r950782408
##########
r/R/type.R:
##########
@@ -58,6 +58,10 @@ FLOAT_TYPES <- c("float16", "float32", "float64",
"halffloat", "float", "double"
#' Infer the arrow Array type from an R object
#'
+#' Infer the arrow Array type from an R object.
Review Comment:
@thisisnic https://arrow.apache.org/docs/developers/reviewing.html says:
> Arrow is a foundational project that will need to evolve over many years
or even decades, while serving potentially millions of users. We believe that
being meticulous when reviewing brings greater rewards to the project than
being lenient and aiming for quick merges.
> Reviewing is a communication between the contributor and the reviewer.
Avoid letting questions or comments remain unanswered for too long (“too long”
is of course very subjective, but two weeks can be a reasonable heuristic). If
you cannot allocate time soon, do say it explicitly. If you don’t have the
answer to a question, do say it explicitly. Saying “I don’t have time
immediately but I will come back later, feel free to ping if I seem to have
forgotten” or “Sorry, I am out of my depth here” is always better than saying
nothing and leaving the other person wondering.
You made the change without waiting for my reply (or ignoring my reply), did
you not?
I hope you will act as like this principle in the future. (Or I may have
misunderstood something. In that case, I am very sorry.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
