marsupialtail commented on code in PR #13931:
URL: https://github.com/apache/arrow/pull/13931#discussion_r950904667
##########
cpp/src/arrow/io/interfaces.h:
##########
@@ -343,5 +344,8 @@ ARROW_EXPORT
Result<Iterator<std::shared_ptr<Buffer>>> MakeInputStreamIterator(
std::shared_ptr<InputStream> stream, int64_t block_size);
+ARROW_EXPORT
+Result<AsyncGenerator<std::shared_ptr<Buffer>>>
MakeRandomAccessFileGenerator(std::shared_ptr<RandomAccessFile> file, int64_t
block_size);
Review Comment:
I think it makes more sense to separate out the readahead generator if you
are going to do this. I personally think a lot of interfaces in Arrow already
have too many flags and it's not very easy for a new person to figure out what
are the good flags to use. I don't think having this generator itself do the
readahead will lead to too many performance benefits either?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
