psvri opened a new issue, #2564:
URL: https://github.com/apache/arrow-rs/issues/2564

   **Which part is this question about**
   Code base: 
https://github.com/apache/arrow-rs/blob/master/arrow/src/array/array_dictionary.rs#L498.
   
   **Describe your question**
   In TypedDictionaryArray value function why do we check for null , we could 
instead assert if the index is less than keys.len() right?
   
   **Additional context**
   the trait documentation states the below, due to which I felt it was bizzare 
that we are checking for null.
   
   ```
   /// A generic trait for accessing the values of an [`Array`]
   pub trait ArrayAccessor: Array {
       type Item: Send + Sync;
   
       /// Returns the element at index `i`
       /// # Panics
       /// Panics if the value is outside the bounds of the array
       fn value(&self, index: usize) -> Self::Item;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to