zeroshade commented on code in PR #13492:
URL: https://github.com/apache/arrow/pull/13492#discussion_r953855106
##########
format/FlightSql.proto:
##########
@@ -761,6 +798,20 @@ enum SqlInfo {
SQL_STORED_FUNCTIONS_USING_CALL_SYNTAX_SUPPORTED = 576;
}
+// The level of support for Flight SQL transaction RPCs.
+enum SqlSupportedTransaction {
+ // Unknown/not indicated
+ SQL_SUPPORTED_TRANSACTION_UNKNOWN = 0;
+ // No support
+ SQL_SUPPORTED_TRANSACTION_NONE = 1;
Review Comment:
yea, I agree that in protobuf you'd distinguish the two in many cases, but
my typical litmus test is if a consumer of the protobuf would treat the
"unknown" case differently than the "none" case. And if there isn't any
functional difference, it's not necessary to distinguish them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
