yahoNanJing commented on code in PR #153:
URL: https://github.com/apache/arrow-ballista/pull/153#discussion_r954427809
##########
ballista/rust/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -390,7 +390,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
.and_then(|m| {
m.try_into_logical_plan(
session_ctx.deref(),
- self.codec.logical_extension_codec(),
+ self.state.codec.logical_extension_codec(),
Review Comment:
Since the codec is already a field of the state and is a necessary field for
the state, I think it's better for the state to own the codec rather than the
server. And it's better to keep unique instance of the codec in case that we
change it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
