dragosmg commented on code in PR #13960: URL: https://github.com/apache/arrow/pull/13960#discussion_r955323763
########## r/R/dplyr-eval.R: ########## @@ -121,3 +128,120 @@ format_expr <- function(x) { } head(out, 1) } + +# vector of function names that do not have corresponding bindings, but we +# shouldn't try to translate +translation_exceptions <- c( + "c", + "$", + "factor", + # "~", + # "(", + "across", + ":", + "[", + "regex", + "fixed", + "list", + "%>%", + # all the types functions + "int8", + "int16", + "int32", + "int64", + "uint8", + "uint16", + "uint32", + "uint64", + "float16", + "halffloat", + "float32", + "float", + "float64", + "boolean", + "bool", + "utf8", + "large_utf8", + "binary", + "large_binary", + "fixed_size_binary", + "string", + "date32", + "date64", + "time32", + "time64", + "duration", + "null", + "timestamp", + "decimal", + "decimal128", + "decimal256" +) + +register_user_bindings <- function(quo, .env) { + unknown_functions_chr <- setdiff( + all_funs(quo), + union( + names(.env), + translation_exceptions + ) + ) + + if (length(unknown_functions_chr != 0)) { Review Comment: Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org