vibhatha commented on code in PR #13401:
URL: https://github.com/apache/arrow/pull/13401#discussion_r956538375
##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -29,10 +29,20 @@
#include "arrow/filesystem/localfs.h"
#include "arrow/filesystem/path_util.h"
#include "arrow/filesystem/util_internal.h"
+#include "arrow/util/checked_cast.h"
+#include "arrow/util/make_unique.h"
namespace arrow {
+
+using internal::checked_cast;
+using internal::make_unique;
+
namespace engine {
+using SubstraitConverter =
std::function<Result<std::unique_ptr<substrait::Rel>>(
+ const std::shared_ptr<Schema>&, const compute::Declaration&, ExtensionSet*,
+ const ConversionOptions&)>;
+
Review Comment:
Yes we used it before with the `registry` but kept it for the above
mentioned reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
