isidentical commented on PR #3228: URL: https://github.com/apache/arrow-datafusion/pull/3228#issuecomment-1229154117
> Isn't the issue then that the propagated filters without column are not added to the plan at all, even when we are at the bottom of a plan? E.g. a propagated where false still should be present regardless of whether it has columns in it. Exactly, at least that is my understanding of this issue. I thought as is, it would be similar to the existing behaviour from #225 but this time done on the projection level rather than filter level. If it makes sense, I can also change the logic in `issue_filters` so that when pushing down we can issue filters for both used filters + all the column-less filters. https://github.com/apache/arrow-datafusion/blob/873b071dff1a6099d30abdd24437e083a60e2686/datafusion/optimizer/src/filter_push_down.rs#L125-L145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
