andygrove commented on code in PR #175:
URL: https://github.com/apache/arrow-ballista/pull/175#discussion_r957951435
##########
ballista/rust/core/proto/datafusion.proto:
##########
@@ -464,11 +468,17 @@ enum AggregateFunction {
APPROX_MEDIAN=15;
APPROX_PERCENTILE_CONT_WITH_WEIGHT = 16;
GROUPING = 17;
+ MEDIAN=18;
+
+ KYLIN_BITMAP_COUNT_DISTINCT=101;
+ KYLIN_APPROX_PERCENTILE=102;
+ KYLIN_APPROX_COUNT_DISTINCT=103;
Review Comment:
What are these? These don't exist in the DataFusion version of this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]