liyafan82 commented on pull request #8245: URL: https://github.com/apache/arrow/pull/8245#issuecomment-699584585
@lidavidm Thanks for your feedback. Please see my reply in line. > LGTM. Two questions: > > * Should we include this in the developer docs in Sphinx, or in the README in the Java subproject? Thanks for the good suggestion. It seems we do not have a development guide for Java. Maybe we should add one in a separate issue. > * How do I run the benchmarks without cleaning and re-building the project? (This seems to do it: `mvn install --also-make -Dskip.perf.benchmarks=false -Dbenchmark.filter=.\*IntBenchmarks.setIntDirectly -pl :arrow-performance`) Good question. We can run ``` mvn exec:exec -Dskip.perf.benchmarks=false ... ``` However, it is fast to rebuild the code, as there are only a few classes in the performance module. Rebuilding is helpful for making the generated benchmark code up to date. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
