lidavidm commented on code in PR #13992:
URL: https://github.com/apache/arrow/pull/13992#discussion_r958791980
##########
go/arrow/array/decimal128.go:
##########
@@ -275,12 +276,12 @@ func (b *Decimal128Builder) unmarshalOne(dec
*json.Decoder) error {
// what got me the closest equivalent values with the values
// that I tested with, and there isn't a good way to push
// an option all the way down here to control it.
- out, _, err = big.ParseFloat(v, 10, 128, big.ToNearestAway)
+ out, _, err = big.ParseFloat(v, 10, 127, big.ToNearestAway)
Review Comment:
Why the change here?
A decimal128 only has 38 digits of precision, FWIW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
