kou commented on code in PR #95:
URL: https://github.com/apache/arrow-adbc/pull/95#discussion_r959060842
##########
adbc.h:
##########
@@ -1061,7 +1048,7 @@ typedef AdbcStatusCode (*AdbcDriverInitFunc)(size_t
count, struct AdbcDriver* dr
struct AdbcError* error);
// For use with count
-#define ADBC_VERSION_0_0_1 27
+#define ADBC_VERSION_0_0_1 26
Review Comment:
OK. I prefer the unique number approach to the number of members approach
for version value.
Because we can support the following case with the unique number approach:
1. An existing callback's signature is changed (e.g. add one more
parameter). (The number of members isn't changed.)
2. Remove a callback and add a new callback. (The number of members isn't
changed.)
But we can avoid these cases by not changing released `AdbcDriver`'s
members. For example, we can just add a new member and deprecate an existing
member for changing signature.
So the number of members approach will work (can keep backward
compatibility) too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
