avantgardnerio commented on code in PR #2586:
URL: https://github.com/apache/arrow-rs/pull/2586#discussion_r959764231
##########
arrow-flight/src/lib.rs:
##########
@@ -254,10 +254,17 @@ impl From<SchemaAsIpc<'_>> for FlightData {
}
}
-impl From<SchemaAsIpc<'_>> for SchemaResult {
- fn from(schema_ipc: SchemaAsIpc) -> Self {
- let IpcMessage(vals) = flight_schema_as_flatbuffer(schema_ipc.0,
schema_ipc.1);
- SchemaResult { schema: vals }
+impl TryFrom<SchemaAsIpc<'_>> for SchemaResult {
+ type Error = ArrowError;
+
+ fn try_from(schema_ipc: SchemaAsIpc) -> ArrowResult<Self> {
Review Comment:
If I understand the thread, it sounds like this has been resolved:
1. use a flag to determine how to write
2. check for the continuation token to differentiate between versions of the
protocol and avoid a breaking change
3. update the protobuf <-> native conversion code
4. add a 4 round-trip tests: old -> new, new -> old, old -> old, new -> new
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
