westonpace commented on code in PR #13959:
URL: https://github.com/apache/arrow/pull/13959#discussion_r959822206
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -350,23 +351,25 @@ class ARROW_DS_EXPORT FileWriter {
/// \brief Options for writing a dataset.
struct ARROW_DS_EXPORT FileSystemDatasetWriteOptions {
/// Options for individual fragment writing.
- std::shared_ptr<FileWriteOptions> file_write_options;
+ std::shared_ptr<FileWriteOptions> file_write_options =
+ CsvFileFormat().DefaultWriteOptions();
Review Comment:
In pyarrow we default to parquet but perhaps that is for legacy reasons.
I'm fine with no default here. However, we should then get rid of the implicit
no-arg constructor and add a single-argument constructor taking in write
options since this will now have a required argument. E.g.
```
FileSystemDatasetWriteOptions(std::shared_ptr<FileWriteOptions>
file_write_options) : file_write_options(std::move(file_write_options)) {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
