paleolimbot commented on code in PR #38: URL: https://github.com/apache/arrow-nanoarrow/pull/38#discussion_r959894571
########## src/nanoarrow/nanoarrow.h: ########## @@ -24,6 +24,81 @@ #include "nanoarrow_types.h" +// If using CMake, optionally pass -DNANOARROW_NAMESPACE=MyNamespace which will set this +// define in build_id.h. If not, you can optionally #define NANOARROW_NAMESPACE +// MyNamespace here. + +// This section remaps the non-prefixed symbols to the prefixed symbols so that +// code written against this build can be used independent of the value of +// NANOARROW_NAMESPACE. +#ifdef NANOARROW_NAMESPACE +#define NANOARROW_CAT(A, B) A##B +#define NANOARROW_SYMBOL(A, B) NANOARROW_CAT(A, B) Review Comment: I think I need them to persist in order for the macro expansion to work (or at least, I can't figure out how to make the build pass if I undefine them (xxHash doesn't seem to undefine them, either). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
