nealrichardson commented on code in PR #39: URL: https://github.com/apache/arrow-nanoarrow/pull/39#discussion_r959982497
########## r/NAMESPACE: ########## @@ -1,4 +1,33 @@ # Generated by roxygen2: do not edit by hand +S3method(as_nanoarrow_array,Array) +S3method(as_nanoarrow_array,ChunkedArray) +S3method(as_nanoarrow_array,RecordBatch) +S3method(as_nanoarrow_array,Table) +S3method(as_nanoarrow_array,default) +S3method(as_nanoarrow_array_stream,RecordBatchReader) +S3method(as_nanoarrow_array_stream,default) +S3method(as_nanoarrow_array_stream,nanoarrow_array_stream) +S3method(as_nanoarrow_schema,DataType) +S3method(as_nanoarrow_schema,Field) +S3method(as_nanoarrow_schema,Schema) +S3method(as_nanoarrow_schema,nanoarrow_schema) Review Comment: My first reaction here is that `as_nanoarrow_array()` feels like a lot to type. But then it makes me wonder: maybe all you need is `to_nanoarrow()`, and then `as.vector()`, `as.data.frame()`, and the `as_*()` methods in `arrow` to go the other way. That's kinda how the C interface works in `arrow`: `export_to_c`, `import_from_c`. Why does it need to be more complicated (of a user interface) than that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
