viirya commented on code in PR #2608:
URL: https://github.com/apache/arrow-rs/pull/2608#discussion_r960034963
##########
arrow/src/compute/kernels/mod.rs:
##########
@@ -35,5 +35,6 @@ pub mod sort;
pub mod substring;
pub mod take;
pub mod temporal;
+// pub(crate) use temporal::extract_component_from_array;
Review Comment:
Oops, forgot to remove. This was left during debugging.
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -1482,25 +1487,35 @@ where
}
/// Cast timestamp types to Utf8/LargeUtf8
-fn cast_timestamp_to_string<T, OffsetSize>(array: &ArrayRef) ->
Result<ArrayRef>
+fn cast_timestamp_to_string<T, OffsetSize>(
+ array: &ArrayRef,
+ tz: &Option<String>,
+) -> Result<ArrayRef>
where
T: ArrowTemporalType + ArrowNumericType,
i64: From<<T as ArrowPrimitiveType>::Native>,
OffsetSize: OffsetSizeTrait,
{
let array = array.as_any().downcast_ref::<PrimitiveArray<T>>().unwrap();
- Ok(Arc::new(
- (0..array.len())
- .map(|ix| {
- if array.is_null(ix) {
- None
- } else {
- array.value_as_datetime(ix).map(|v| v.to_string())
- }
- })
- .collect::<GenericStringArray<OffsetSize>>(),
- ))
+ let mut builder = GenericStringBuilder::<OffsetSize>::new();
+
+ if let Some(tz) = tz {
+ let mut scratch = Parsed::new();
+ extract_component_from_array!(
Review Comment:
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
