MingyuZhong commented on a change in pull request #8279:
URL: https://github.com/apache/arrow/pull/8279#discussion_r496114216
##########
File path: cpp/src/arrow/util/basic_decimal.cc
##########
@@ -251,9 +252,9 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
namespace {
void ExtendAndMultiplyUint64(uint64_t x, uint64_t y, uint64_t* hi, uint64_t*
lo) {
-#ifdef __SIZEOF_INT128__
+#ifdef ARROW_USE_NATIVE_INT128
const __uint128_t r = static_cast<__uint128_t>(x) * y;
- *lo = r & 0xffffffffffffffff;
+ *lo = r & kIntMask;
Review comment:
kInt64Mask
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
