HaoYang670 commented on PR #2621: URL: https://github.com/apache/arrow-rs/pull/2621#issuecomment-1235060450
Unfortunately, I don't find a definition of which types are numeric in the Arrow format: https://github.com/apache/arrow/blob/master/format/Schema.fbs We have a trait `ArrowNumbericType` in arrow-rs, but there is no doc to describe what is it and why we need it. In datafusion, the definition of `is_numeric` is here: https://github.com/apache/arrow-datafusion/blob/master/datafusion/expr/src/binary_rule.rs#L392-L414. It covers the types in `DataType::is_numeric` and `Float16` and `Decimal128`. This PR is trying to build a consistent definition of `DataType::is_numeric` and `is_numeric` in the Datafusion, so that we could remove the `is_numeric` in Datafusion and users will not get confused when choosing between the two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
