viirya commented on PR #2623: URL: https://github.com/apache/arrow-rs/pull/2623#issuecomment-1235220059
> Perhaps we could keep the signature the same, but provide a more generic version with a suffix, e.g. `_generic`. Otherwise this is an ergonomic step-back for the case of a non-dictionary encoded array, which is likely by far the common case Yea, I was hesitating between adding `_generic` version and replacing existing kernel names. Ideally I'd like to provide the kernels of same names but are generic version. But as you seen, it comes along with the loss of automatic type hinting in the end. I will add `_generic` suffix to these new kernels and add back the original ones with same signature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
