ghubkoa commented on PR #3354: URL: https://github.com/apache/arrow-datafusion/pull/3354#issuecomment-1236425887
@alamb @xudong963 I need help to fix this PR. After spending some time on this I was able to figure out that the JIT tests are failing with below message. `(signal: 11, SIGSEGV: invalid memory reference)` The error happens when calling the function `code_fn` https://github.com/apache/arrow-datafusion/blob/b175f9a48d296ea66a07acc3825f4d6e0def2367/datafusion/row/src/jit/reader.rs#L57 The function `code_fn` is dynamically assigned in below lines https://github.com/apache/arrow-datafusion/blob/b175f9a48d296ea66a07acc3825f4d6e0def2367/datafusion/row/src/jit/reader.rs#L48-L53 And signature of the `gen_func` function is defined below https://github.com/apache/arrow-datafusion/blob/b175f9a48d296ea66a07acc3825f4d6e0def2367/datafusion/row/src/jit/reader.rs#L71-L75 I need to make changes in two places 1. While calling `reg_fn!` the last parameter should represent `Result` instead of `None`. I am not able to figure out how to pass `Result`. Looks like JIT is capable of handling primitive types. I tried `Some(PTR)` and it did not work. 2. In `mem:: transmute`, I think I need to change the signature to return `Result`. But not sure if this is enough. Do you guys have any inputs on how to go about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
