avantgardnerio commented on PR #3279: URL: https://github.com/apache/arrow-datafusion/pull/3279#issuecomment-1236455949
> review again and see if this meets your expectations now? @alamb and @psvri , my concern was regarding the implementation based upon retaining the original raw SQL string. The issue this is resolving had a suggested implementation: > This will probably require implementing Display for DFStatement to convert it back into SQL, or generating SQL in register_listing_table. And that was more in line with my thoughts: - we parse it into fields, and store those fields - we also store the original parse string This seems strange to me, in that it will carry over irrelevant syntax differences, and also stores redundant information. When I ask postgres to show a table, I don't get my raw SQL back, I get back generated SQL that matches the definition postgres has an internal representation for. It bothers me, but I'm not sure if I'm being pedantic I'll leave it to you @alamb . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
