kou commented on code in PR #14045:
URL: https://github.com/apache/arrow/pull/14045#discussion_r963277187
##########
docs/source/cpp/build_system.rst:
##########
@@ -51,7 +51,7 @@ file into an executable linked with the Arrow C++ shared
library:
find_package(Arrow REQUIRED)
add_executable(my_example my_example.cc)
- target_link_libraries(my_example PRIVATE arrow_shared)
+ target_link_libraries(my_example PRIVATE Arrow::arrow_shared)
Review Comment:
We recommend `Arrow::arrow_shared`. So this change is preferred.
FYI: Users can still use `arrow_shared` with CMake 3.18 or later for
backward compatibility.
See also:
https://github.com/apache/arrow/blob/master/cpp/src/arrow/ArrowConfig.cmake.in#L110-L121
BTW, we have a Jira issue to update this document: ARROW-17575
If you take over this, I'm very happy!
Here are some notes for the new our CMake packages:
* Users can use `find_package(Arrow)`, `find_package(Parquet)` and so on as
usual but can't use `COMPONENTS` like `find_package(Arrow COMPONENTS parquet)`
* The old our CMake packages just ignore `COMPONENTS`.
* `Arrow::arrow_shared` is recommended than `arrow_shared`
* `CMAKE_PREFIX_PATH` not `PKG_CONFIG_PATH` should be used to find Apache
Arrow C++ that isn't installed to the system location such as `/usr`
* The old our CMake packages also uses `PKG_CONFIG_PATH` (`.pc` can be
used to find the `Arrow` CMake package)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
