rtpsw commented on PR #14041: URL: https://github.com/apache/arrow/pull/14041#issuecomment-1237810404
@westonpace, I see you were involved in the [`Enumerated` code](https://github.com/apache/arrow/blame/master/cpp/src/arrow/util/async_generator.h#L1501-L1506) and I'd like to ask about it. Why `int`, and not `int64_t` for the index type? When I tried to change to `int64_t`, I observed failures in `arrow-dataset-datasdt-test` like: ``` [ RUN ] TestEndToEnd.EndToEndSingleDataset /mnt/user1/tscontract/github/rtpsw/arrow/cpp/src/arrow/dataset/dataset_test.cc:468: Failure Failed '_error_or_value141.status()' failed with Invalid: Referenced field __fragment_index was int64 but should have been int32 [ FAILED ] TestEndToEnd.EndToEndSingleDataset (6 ms) ``` which could probably be fixed in the tester. Also, why `int` and not `int32_t`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
