andygrove commented on code in PR #3365:
URL: https://github.com/apache/arrow-datafusion/pull/3365#discussion_r964067463
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -962,10 +965,10 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
let scalar_type = match boxed_field.data_type() {
DataType::List(field) =>
field.as_ref().data_type(),
unsupported => {
- todo!("Proper error handling {}",
unsupported)
+ return Err(Error::General(format!("Proto
serialization error: {:?} not supported to convert to DataType::List",
unsupported)));
}
};
- println!("Current scalar type for list: {:?}",
scalar_type);
+ //println!("Current scalar type for list: {:?}",
scalar_type);
Review Comment:
Debug logging can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
