lidavidm commented on code in PR #14056:
URL: https://github.com/apache/arrow/pull/14056#discussion_r965221897
##########
ci/scripts/go_test.sh:
##########
@@ -19,12 +19,20 @@
set -ex
+# simplistic semver comparison
+verlte() {
+ [ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ]
Review Comment:
:rofl:
##########
go/arrow/array/struct.go:
##########
@@ -36,6 +36,37 @@ type Struct struct {
fields []arrow.Array
}
+// NewStructArray constructs a new Struct Array out of the columns passed
+// in and the field names. The length of all cols must be the same and
+// there should be the same number of columns as names.
+func NewStructArray(cols []arrow.Array, names []string) (*Struct, error) {
+ return NewStructArrayWithNulls(cols, names, nil, 0, 0)
+}
+
+func NewStructArrayWithNulls(cols []arrow.Array, names []string, nullBitmap
*memory.Buffer, nullCount int, offset int) (*Struct, error) {
Review Comment:
Should this have a docstring too?
##########
go/arrow/datatype.go:
##########
@@ -192,6 +192,7 @@ type FixedWidthDataType interface {
DataType
// BitWidth returns the number of bits required to store a single
element of this data type in memory.
BitWidth() int
+ Bytes() int
Review Comment:
Probably deserves a docstring too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
