sunchao commented on code in PR #2673:
URL: https://github.com/apache/arrow-rs/pull/2673#discussion_r965350779
##########
arrow/src/array/ord.rs:
##########
@@ -101,6 +126,27 @@ where
})
}
+macro_rules! cmp_dict_primitive {
Review Comment:
could we use a method here? seems the only reason is because of returning
`Err`. I think we can just panic here since the dictionary key type can't be
anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
